RFR: 8367397: Improve naming and terminology in regmask.hpp and regmask.cpp [v7]

Emanuel Peter epeter at openjdk.org
Sat Sep 13 04:52:12 UTC 2025


On Fri, 12 Sep 2025 22:12:03 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename InfiniteStack_size and fix style of touched code
>
> src/hotspot/share/opto/regmask.hpp line 173:
> 
>> 171:   }
>> 172: 
>> 173:   void set_infinite() {
> 
> Suggestion:
> 
>   void set_infinite_stack() {
> 
> For consistency with `is_infinite_stack()`.

Yes, it should be `set_infinite_stack` in parallel with `is_infinite_stack`, nice catch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27215#discussion_r2345896440


More information about the hotspot-compiler-dev mailing list