RFR: 8361702: C2: assert(is_dominator(compute_early_ctrl(limit, limit_ctrl), pre_end)) failed: node pinned on loop exit test? [v4]

[Emanuel Peter]

On Tue, 26 Aug 2025 09:27:04 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/rangechecks/TestSunkRangeFromPreLoopRCE3.java line 28:
>> 
>>> 26:  * @bug 8361702
>>> 27:  * @summary C2: assert(is_dominator(compute_early_ctrl(limit, limit_ctrl), pre_end)) failed: node pinned on loop exit test?
>>> 28:  * @requires vm.flavor == "server"
>> 
>> Would this test fail without this requires? Or could we remove it, in the hopes of catching something else somewhere else?
>
> The `@requires` is there because the test run needs command line options that are c2 specific.

Ok, but then you should make the run below without flags in a separate `@test` that does not have this restriction.

@rwestrel

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26424#discussion_r2348419584
PR Review Comment: https://git.openjdk.org/jdk/pull/26424#discussion_r2348424709