RFR: 8367657: C2 SuperWord: NormalMapping demo from JVMLS 2025 [v3]
Emanuel Peter
epeter at openjdk.org
Tue Sep 16 07:41:50 UTC 2025
On Tue, 16 Sep 2025 06:49:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix inlining
>
> test/hotspot/jtreg/compiler/gallery/NormalMapping.java line 121:
>
>> 119: }
>> 120:
>> 121: public static File getLocalFile(String name) {
>
> Isn't `name` always constant (i.e. `normal_map.png`)? Then you could also extract that to a constant and use it here directly.
I would like to allow the user to add their own images. I used to have multiple, but the file sizes are a bit of an issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27282#discussion_r2351248006
More information about the hotspot-compiler-dev
mailing list