RFR: 8367657: C2 SuperWord: NormalMapping demo from JVMLS 2025 [v3]

Emanuel Peter epeter at openjdk.org
Tue Sep 16 07:42:42 UTC 2025


On Tue, 16 Sep 2025 06:50:50 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix inlining
>
> test/hotspot/jtreg/compiler/gallery/NormalMapping.java line 88:
> 
>> 86:         System.out.println("Welcome to the Normal Mapping Demo!");
>> 87:         // Create an applicateion state with 5 lights.
>> 88:         State state = new State(5);
> 
> I suggest to put `5` into a named constant. This invites to play around with different number of lights.

Nice idea!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27282#discussion_r2351262820


More information about the hotspot-compiler-dev mailing list