RFR: 8367728: IGV: dump node address type

[Marc Chevalier]

On Tue, 16 Sep 2025 11:49:11 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> src/hotspot/share/opto/idealGraphPrinter.cpp line 452:
>> 
>>> 450:     }
>>> 451:     if (n->adr_type() != nullptr) {
>>> 452:       stringStream adr_type_stream;
>> 
>> Other stringStream around are using a preallocated buffer. Would it be a good idea here too?
>
> Thanks for bringing this up. I did not use the pre-allocated buffer for simplicity, which I think I is more important than efficiency in this code - as long as the efficiency is not bad enough to turn into a usability problem. We should probably investigate (separately) simplifying all other uses of `stringStream` in the IGV dumping logic.

I think that makes sense. Thanks.

No strong opinion whether we should change what is already there, as long as we don't add more.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27310#discussion_r2352218330