RFR: 8325467: Support methods with many arguments in C2 [v27]
Emanuel Peter
epeter at openjdk.org
Tue Sep 16 14:24:51 UTC 2025
On Tue, 16 Sep 2025 12:08:25 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> src/hotspot/share/opto/postaloc.cpp line 685:
>>
>>> 683: assert(is_adjacent || is_reg,
>>> 684: "only registers can be non-adjacent");
>>> 685: if (!value[ureg_lo] && is_adjacent) { // Nearly always adjacent
>>
>> `value[ureg_lo]` returns a `Node*`, right? Then that would make this an implicit null check, not allowed by style guide ;)
>
> Here I'll argue not touching this in this PR (I did not introduce this), as this is the style of the surrounding code. Should be addressed in a follow-up PR though.
I'd say this is not just formatting/naming, but code style. We usually fix these cases when we touch the code ;)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2352685909
More information about the hotspot-compiler-dev
mailing list