RFR: 8367333: C2: Vector math operation intrinsification failure [v2]
Vladimir Ivanov
vlivanov at openjdk.org
Tue Sep 16 20:09:22 UTC 2025
On Tue, 16 Sep 2025 06:44:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review feedback
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorMathLib.java line 33:
>
>> 31: * @test
>> 32: * @bug 8367333
>> 33: * @requires vm.compiler2.enabled
>
> Do you need this `@requires`? It might be nice to be able to run this with other compilers too.
It's intended as C2-specific regression test and it relies on C2-specific VM flags. Vector API unit tests (under test/jdk/jdk/incubator/vector/) exercise the very same functionality, but don't specify flags required to trigger the bug.
> test/hotspot/jtreg/compiler/vectorapi/TestVectorMathLib.java line 40:
>
>> 38: * -XX:CompileCommand=compileonly,compiler.vectorapi.TestVectorMathLib::test*
>> 39: * -XX:+StressIncrementalInlining
>> 40: * compiler.vectorapi.TestVectorMathLib
>
> Like @jatin-bhateja mentioned: alignment is off.
> I'd also like to see a run without flags, maybe with only `-XX:CompileCommand=compileonly,compiler.vectorapi.TestVectorMathLib::test*`
Again, IMO it doesn't make sense to run the regression test without stressing incremental inlining. Otherwise, it duplicates existing tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27263#discussion_r2353525672
PR Review Comment: https://git.openjdk.org/jdk/pull/27263#discussion_r2353527146
More information about the hotspot-compiler-dev
mailing list