RFR: 8366333: AArch64: Enhance SVE subword type implementation of vector compress [v2]

[Emanuel Peter]

On Wed, 17 Sep 2025 03:14:02 GMT, erifan <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorapi/VectorCompressTest.java line 36:
>> 
>>> 34:  * @key randomness
>>> 35:  * @library /test/lib /
>>> 36:  * @summary AArch64: Enhance SVE subword type implementation of vector compress
>> 
>> I would change the summary to something a bit more generic, since the test is not only good for aarch64 / SVE.
>> Suggestion:
>> 
>>  * @summary IR test for VectorAPI compress
>
> It seems that the summary and the PR title are usually consistent. Is there any convention or rule for this?

I think that people often just do whatever they feel like. But I think the summary should summarize the content of the test, give maybe a reason for the test. Sometimes the PR title captures the intent of the test, then I'm fine with that. But sometimes the PR title is not quite adequate, maybe too narrow like here. But it is not a big deal, just a little nit ;)

>> test/hotspot/jtreg/compiler/vectorapi/VectorCompressTest.java line 228:
>> 
>>> 226:                      .start();
>>> 227:     }
>>> 228: }
>> 
>> Question: is there already another test that checks `compress`?
>
> Yes, just like `expand`, it's here https://github.com/openjdk/jdk/blob/986ecff5f9b16f1b41ff15ad94774d65f3a4631d/test/jdk/jdk/incubator/vector/Byte128VectorTests.java#L5357
> This test file is mainly for IR test.

Nice, thanks! I forgot to search over there 🙈

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27188#discussion_r2354439774
PR Review Comment: https://git.openjdk.org/jdk/pull/27188#discussion_r2354435654