RFR: 8325467: Support methods with many arguments in C2 [v27]

Daniel Lundén dlunden at openjdk.org
Wed Sep 17 09:55:35 UTC 2025


On Tue, 16 Sep 2025 12:42:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 39 commits:
>> 
>>  - Clarify comments in regmask.hpp
>>  - Merge remote-tracking branch 'upstream/master' into many-arguments-8325467+pr-updates
>>  - Address review comments (renaming on the way in a separate PR)
>>  - Update src/hotspot/share/opto/regmask.hpp
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>>  - Restore modified java/lang/invoke tests
>>  - Sort includes (new requirement)
>>  - Merge remote-tracking branch 'upstream/master' into many-arguments-8325467+pr-updates
>>  - Add clarifying comments at definitions of register mask sizes
>>  - Fix implicit zero and nullptr checks
>>  - Add deep copy comment
>>  - ... and 29 more: https://git.openjdk.org/jdk/compare/60930a3e...c1f41288
>
> test/hotspot/jtreg/compiler/arguments/TestMethodArguments.java line 120:
> 
>> 118:                 Template.let("classpath", comp.getEscapedClassPathOfCompiledClasses()),
>> 119:                 """
>> 120:                         import java.util.Arrays;
> 
> Personally, I would not indent this deeply. I know that the generated code will not have proper indentation, but that's no so bad. Readability of the Templates is more important I think. Subjective though.

No strong opinion here, I just went with the eclipse-jdtls autoformatter defaults. The generated code does have fairly OK indentation (the indentation in the code does not add any actual indentation in the generated code). Let me know what you prefer and I'll update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2354957995


More information about the hotspot-compiler-dev mailing list