RFR: 8325467: Support methods with many arguments in C2 [v23]

Daniel Lundén dlunden at openjdk.org
Wed Sep 17 09:58:56 UTC 2025


On Tue, 16 Sep 2025 14:36:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> @eme64 I have now addressed your comments (the renaming is in https://github.com/openjdk/jdk/pull/27215, as requested). Please have a look and let me know if I've missed something.
>
> @dlunde Thanks for the swift updates! I have in the meantime added some more comments, just making sure you don't miss them :)

@eme64

> You seem to have a build failure:
> 
> ```
> In file included from /home/runner/work/jdk/jdk/src/hotspot/share/opto/compile.hpp:43,
>                  from /home/runner/work/jdk/jdk/src/hotspot/share/opto/type.hpp:29,
>                  from /home/runner/work/jdk/jdk/test/hotspot/gtest/opto/test_rangeinference.cpp:26:
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/regmask.hpp: In constructor ‘RegMask::RegMask(Arena*)’:
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/regmask.hpp:441:53: error: class ‘RegMask’ does not have any field named ‘_read_only’
>   441 |       : _rm_word() DEBUG_ONLY(COMMA _arena(arena)), _read_only(read_only),
>       |                                                     ^~~~~~~~~~
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/regmask.hpp:441:64: error: ‘read_only’ was not declared in this scope
>   441 |       : _rm_word() DEBUG_ONLY(COMMA _arena(arena)), _read_only(read_only),
>       |     
> ```

Thanks, only failed on release so didn't notice. Will fix.

> I really appreciate that you added extensive `gtest`s, thanks for that 😊

@robcasloz contributed 90% of that, so the credit goes to him!

> And thanks for using the Template Framework, I'm curious to hear if you have any feedback on it :)

Sure, it was quite convenient. Happy to talk about the experience offline.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20404#issuecomment-3302233210


More information about the hotspot-compiler-dev mailing list