RFR: 8367740: assembler_<cpu>.inline.hpp should not include assembler.inline.hpp

Damon Fenacci dfenacci at openjdk.org
Thu Sep 18 07:00:38 UTC 2025


On Tue, 16 Sep 2025 10:15:06 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

> This is the content of assembler.inline.hpp:
> https://github.com/openjdk/jdk/blob/ca89cd06d39ed3a6bbe16f60fea4d7382849edbd/src/hotspot/share/asm/assembler.inline.hpp#L28-L30
> 
> Most of the `assembler_<cpu>.inline.hpp` include it:
> https://github.com/openjdk/jdk/blob/ca89cd06d39ed3a6bbe16f60fea4d7382849edbd/src/hotspot/cpu/zero/assembler_zero.inline.hpp#L29-L32
> 
> They should probably include `assembler.hpp` instead.
> 
> Testing: tier1 in GHA

Tests passed. Thanks @fandreuz. LGTM

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/27311#pullrequestreview-3237615976


More information about the hotspot-compiler-dev mailing list