RFR: 8359412: Template-Framework Library: Operations and Expressions [v3]

[Emanuel Peter]

On Wed, 17 Sep 2025 11:02:12 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply Manuel's suggestions part 2
>
> test/hotspot/jtreg/compiler/lib/template_framework/library/Expression.java line 152:
> 
>> 150: 
>> 151:     /**
>> 152:      * Creates a new Espression with 1 arguments.
> 
> For every make(): s/Espression/Expression/

Nice catch!

> test/hotspot/jtreg/compiler/lib/template_framework/library/Expression.java line 164:
> 
>> 162:                                   CodeGenerationDataNameType t0,
>> 163:                                   String s1) {
>> 164:         return new Expression(returnType, List.of(t0), List.of(s0, s1), new Info());
> 
> To reduce code duplication, the methods without an additional info should probably use the ones with.
> Suggestion:
> 
>         return make(returnType, s0, t0, s1, new Info());

Nice idea :)

> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestExpressions.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8359412
>> 27:  * @summary Demonstrate the use of Expressions form the Template Library.
> 
> Suggestion:
> 
>  * @summary Demonstrate the use of Expressions from the Template Library.
> 
> Typo

Done :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26885#discussion_r2357779934
PR Review Comment: https://git.openjdk.org/jdk/pull/26885#discussion_r2357777770
PR Review Comment: https://git.openjdk.org/jdk/pull/26885#discussion_r2357782258