RFR: 8367613: Test compiler/runtime/TestDontCompileHugeMethods.java failed [v2]
Man Cao
manc at openjdk.org
Fri Sep 19 08:04:11 UTC 2025
On Tue, 16 Sep 2025 08:10:11 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Man Cao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Switch to disable inlining for shortMethod
>
> When looking at the test, it seems that we want to verify that `shortMethod()` is compiled while `hugeSwitch()` is not. When running with `-Xcomp`, we will immediately compile `main()` and directly inline `shortMethod()` with C1 (with C2 we fail to inline with "failed initial checks" and thus will compile `shortMethod()` separately when calling it the first time). Therefore, with C1, we will not compile `shortMethod()` separately and the test fails.
>
> Excluding `-Xcomp` looks reasonable. An alternative would be to exclude `main()` from compilation. But I think for the purpose of this test, excluding `-Xcomp` seems better.
@chhagedorn Could you also approve the latest commit?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27306#issuecomment-3311081698
More information about the hotspot-compiler-dev
mailing list