RFR: 8350468: x86: Improve implementation of vectorized numberOfLeadingZeros for int and long
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Mon Sep 22 03:03:24 UTC 2025
On Mon, 4 Aug 2025 02:20:31 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
> Hi all,
> This is a patch that optimizes the x86 backend implementation of `CountLeadingZerosV` for int and long. In the review of [JDK-8349637)](https://bugs.openjdk.org/browse/JDK-8349637) an [optimized algorithm]( https://github.com/openjdk/jdk/pull/23579#issuecomment-2661332497) was proposed by @rgiulietti, which this PR implements. For integer operands, the optimized algorithm reduces the number of vector instructions from 19 to 13. The same algorithm does not work for long operands, however, since avx2 lacks a vectorized long->double conversion instruction. Instead, I found an optimized algorithm to reuse the code for int and compute the leading zeros for long with only 4 additional instructions. I added a benchmark and on my Zen 3 machine I get these results:
>
> Baseline Patch
> Benchmark Mode Cnt Score Error Units Score Error Units Improvement
> LeadingZeros.testInt avgt 15 91.097 ± 3.276 ns/op 68.665 ± 1.740 ns/op (+ 28.1%)
> LeadingZeros.testLong avgt 15 342.545 ± 4.470 ns/op 228.668 ± 5.994 ns/op (+ 39.9%)
>
> I've updated the unit tests to more thoroughly test longs and they pass on my machine. Thoughts and reviews would be appreciated!
Hi! May I have some reviews on this? Maybe @jatin-bhateja or @sviswa7 since this is an x86 backend change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26610#issuecomment-3316600692
More information about the hotspot-compiler-dev
mailing list