RFR: 8349835: C2: simplify IGV property printing
Damon Fenacci
dfenacci at openjdk.org
Mon Sep 22 06:54:20 UTC 2025
On Mon, 22 Sep 2025 06:41:46 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> The code that prints node properties and live range properties is very verbose and repetitive and could be simplified by applying a refactoring suggested [here](https://github.com/openjdk/jdk/pull/23558#discussion_r1950785708).
>>
>> ### Fix
>> Implemented the suggested refactoring.
>>
>> ### Testing
>> Github Actions, Tier 1-3
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 534:
>
>> 532: {((flags & Node::Flag_has_call) != 0), "has_call", "true"},
>> 533: {((flags & Node::Flag_has_swapped_edges) != 0), "has_swapped_edges", "true"}
>> 534: };
>
> The indentation seems a bit off.
BTW we might want to use `TRUE_VALUE` instead of `"true"` here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2366890675
More information about the hotspot-compiler-dev
mailing list