RFR: 8349835: C2: simplify IGV property printing
Saranya Natarajan
snatarajan at openjdk.org
Tue Sep 23 07:55:24 UTC 2025
On Fri, 22 Aug 2025 13:28:22 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:
> The code that prints node properties and live range properties is very verbose and repetitive and could be simplified by applying a refactoring suggested [here](https://github.com/openjdk/jdk/pull/23558#discussion_r1950785708).
>
> ### Fix
> Implemented the suggested refactoring.
>
> ### Testing
> Github Actions, Tier 1-3
Thank you for the review.
@jdksjolen : I did think of tagged unions while fixing the issue. I did not implement it as my understanding was that it necessarily does not decrease the code size. However, I agree it is better than the current implementation. I plan to try out the changes suggested by @chhagedorn to see if it introduces more opportunities to refactor 'visit_node()'. If it is not feasible, I fall back to tagged union.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26902#issuecomment-3322823817
More information about the hotspot-compiler-dev
mailing list