RFR: 8368525: nmethod ic cleanup

[Christian Hagedorn]

On Wed, 24 Sep 2025 09:50:24 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple patch?
> 
> There is some unused parameter and unnecessary/misleading method in nmethod.cpp, better to clean it up.
> I guess it might be a leftover after some previous refactoring? But I did not check further.
> 
> Thanks!

Looks good, thanks for cleaning it up!

src/hotspot/share/code/nmethod.cpp line 871:

> 869:         // If class unloading occurred we first clear ICs where the cached metadata
> 870:         // is referring to an unloaded klass or method.
> 871:         CompiledIC_at(&iter)->clean_metadata();;

Suggestion:

        CompiledIC_at(&iter)->clean_metadata();

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27464#pullrequestreview-3262382473
PR Review Comment: https://git.openjdk.org/jdk/pull/27464#discussion_r2375428238