RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v7]

[Benoît Maillard]

On Wed, 24 Sep 2025 06:55:29 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More comments
>
> src/hotspot/share/opto/loopTransform.cpp line 1672:
> 
>> 1670: 
>> 1671: Node* PhaseIdealLoop::find_last_store_in_outer_loop(Node* store, IdealLoopTree* outer_loop) {
>> 1672:   Node* out = store;
> 
> Since you want a store, you should probably assert that `store` is not null and actually a store.

Good point, done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27225#discussion_r2387154178