RFR: 8364305: Support AVX10 saturating floating point conversion instructions [v18]
    Richard Reingruber 
    rrich at openjdk.org
       
    Tue Sep 30 06:03:04 UTC 2025
    
    
  
On Fri, 26 Sep 2025 23:53:41 GMT, Mohamed Issa <missa at openjdk.org> wrote:
>> I haven't thoroughly reviewed the patch, but what caught my eye is that avx10 and avx10_2 are used interchangeably which adds confusion. My recollection is that AVX10.1 is equivalent to AVX512 set of capabilities. Can we uniformly refer to AVX10.2 as AVX10 in the code base then?
>
>> I haven't thoroughly reviewed the patch, but what caught my eye is that avx10 and avx10_2 are used interchangeably which adds confusion. My recollection is that AVX10.1 is equivalent to AVX512 set of capabilities. Can we uniformly refer to AVX10.2 as AVX10 in the code base then?
> 
> In the future, we could get AVX10.3 which would be superset of AVX10.2. So, these new floating point conversion instructions would apply to AVX10.3 as well. With that in mind, I think it's useful to have the generic AVX10 label as an umbrella and then distinguish between sub-versions when strictly necessary.
> 
> Is the main issue that each AVX10 reference (e.g., `C2_MacroAssembler::vector_castF2X_avx10`) isn't descriptive enough about which minimum sub-version is in use at a quick glance? Or are other concerns that should be addressed?
Hi @missa-prime would you mind reviewing https://github.com/openjdk/jdk/pull/27546?
It removes x86 specific IR checks for the case where avx10.2 is not available.
The tests fail on ppc64 because it obviously hasn't got avx and the IR is a little different to x86 too.
Thanks, Richard.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26919#issuecomment-3350092761
    
    
More information about the hotspot-compiler-dev
mailing list