RFR: 8368861: [TEST] compiler/floatingpoint/ScalarFPtoIntCastTest.java expects x86 IR on non-x86 platforms

[Manuel Hässig]

On Mon, 29 Sep 2025 12:31:22 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This removes X86 specific IR checks that are applied if the X86 specific feature *avx10_2* is not present.
> 
> We could make the checks dependent on the platform being X86 if we wanted to keep them but I don't see a value in doing so.
> 
> Tested on X86 and PPC64

Thank you for working on this, @reinrich.

Quite frankly, I would much prefer, if you kept the IR rules and added the x86 platform predicate, as in my suggestion below. It is just a bit more coverage we will exercise in out test suite.

test/hotspot/jtreg/compiler/floatingpoint/ScalarFPtoIntCastTest.java line 90:

> 88:     @Test
> 89:     @IR(counts = {IRNode.CONV_F2I, "> 0"})
> 90:     @IR(counts = {IRNode.X86_SCONV_F2I_AVX10, "> 0"},

Suggestion:

    @IR(counts = {IRNode.CONV_F2I, "> 0"})
    @IR(counts = {IRNode.X86_SCONV_F2I, "> 0"},
        applyIfPlatform = {"x64", "true"},
        applyIfCPUFeature = {"avx10_2", "false"})
    @IR(counts = {IRNode.X86_SCONV_F2I_AVX10, "> 0"},

-------------

Changes requested by mhaessig (Committer).

PR Review: https://git.openjdk.org/jdk/pull/27546#pullrequestreview-3284603718
PR Review Comment: https://git.openjdk.org/jdk/pull/27546#discussion_r2391335073