RFR: 8373724: Assertion failure in TestSignumVector.java with UseAPX [v4]

[Jatin Bhateja]

> Existing demotable instruction patterns for negI/L_rReg_ndd have 'src' as their second operand, this leads to an failure during register biasing. Changing the NDD demotion flags names to encode explicit operand position i.e. **Flag_ndd_demotable_opr1 and Flag_ndd_demotable_opr2** , splitting commutative flag into seperate new flags and fine tuning assertion checks based on new naming convention fixes the issue.
> 
> Failing test test/hotspot/jtreg/compiler/vectorization/TestSignumVector.java passes with the patch.
> 
> Kindly review and share your feedback.
> 
> Best Regards,
> Jatin
> PS: Validation performed using Intel SDE 9.58.

Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Use ASSERT pre-processor macro instead of PRODUCT to fix optimized build failure
 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8373724
 - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8373724
 - 8373724: Assertion failure in TestSignumVector.java with UseAPX

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28999/files
  - new: https://git.openjdk.org/jdk/pull/28999/files/2a63c92b..05db5651

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28999&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28999&range=02-03

  Stats: 925 lines in 37 files changed: 628 ins; 238 del; 59 mod
  Patch: https://git.openjdk.org/jdk/pull/28999.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28999/head:pull/28999

PR: https://git.openjdk.org/jdk/pull/28999