RFR: 8373724: Assertion failure in TestSignumVector.java with UseAPX [v5]

[Jatin Bhateja]

On Mon, 5 Jan 2026 18:02:50 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright
>
> src/hotspot/cpu/x86/x86.ad line 14000:
> 
>> 13998:   match(Set dst (OrL src1 (LoadL src2)));
>> 13999:   effect(KILL cr);
>> 14000:   flag(PD::Flag_sets_sign_flag, PD::Flag_sets_zero_flag, PD::Flag_sets_parity_flag, PD::Flag_clears_overflow_flag, PD::Flag_clears_carry_flag, PD::Flag_ndd_demotable_opr1, PD::Flag_ndd_demotable_opr2);
> 
> Remove PD::Flag_ndd_demotable_opr2 as the second operand is a memory operand.

We already have a check for [memory operands (mapping to multiple input edges](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L2664)) in place, ADLC generates DFA for both direct and flipped versions of the memory patterns. So Flag_ndd_demotable_opr2 will cover the flipped operand case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28999#discussion_r2663532523