RFR: 8373555: C2: Optimize redundant input calculations for sign comparisons [v2]

[Manuel Hässig]

On Thu, 8 Jan 2026 08:27:32 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright year
>
> src/hotspot/share/opto/subnode.cpp line 1556:
> 
>> 1554:   }
>> 1555:   BasicType bt = cop == Op_CmpI ? T_INT : T_LONG;
>> 1556:   Node* in_op = cmp->in(1);
> 
> Please assert the precondition that `cmp->in(2)` is a zero constant.

Also, asserting the test is what we expect would also be good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28782#discussion_r2671610528