RFR: 8373343: C2: verify AddP base input only set for heap addresses [v4]

[Christian Hagedorn]

On Wed, 7 Jan 2026 08:16:55 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The base input of `AddP` is expected to only be set for heap accesses
>> but I noticed some inconsistencies so I added an assert in the `AddP`
>> constructor and fixed issues that it caught. AFAFICT, the
>> inconsistencies shouldn't create issues.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - more
>  - more
>  - review
>  - Merge branch 'master' into JDK-8373343
>  - review
>  - review
>  - review
>  - merge
>  - more
>  - more
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/c28f62fa...b20f41db

Update looks good! Let me this another spin in our testing.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28769#pullrequestreview-3639046036