RFR: 8373134: C2: Min/Max users of Min/Max uses should be enqueued for GVN [v6]
Emanuel Peter
epeter at openjdk.org
Fri Jan 9 13:49:54 UTC 2026
On Fri, 9 Jan 2026 13:40:13 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Galder Zamarreño has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into topic.uses-min-max
>> - Module also needed in the wrapper test class
>> - It's the templated test that needs the module
>> - Add missing module to test
>> - Merge branch 'master' into topic.uses-min-max
>> - Test Float16
>> - Only apply to uses that match original IR node
>> - Merge branch 'master' into topic.uses-min-max
>> - Use is_MinMax() instead of spelling out individual Min/Max opcodes
>> - Refactor MaxNode to MinMaxNode and add is_MinMax() query
>> - ... and 3 more: https://git.openjdk.org/jdk/compare/067fd3cb...7229e345
>
> src/hotspot/share/opto/addnode.hpp line 334:
>
>> 332:
>> 333: public:
>> 334: MinMaxNode( Node *in1, Node *in2 ) : AddNode(in1,in2) {
>
> Suggestion:
>
> MinMaxNode(Node* in1, Node* in2) : AddNode(in1, in2) {
>
> Might as well fix code style while touching it.
Do the same below ;)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28895#discussion_r2676235821
More information about the hotspot-compiler-dev
mailing list