RFR: 8373134: C2: Min/Max users of Min/Max uses should be enqueued for GVN [v6]
Emanuel Peter
epeter at openjdk.org
Mon Jan 12 07:02:12 UTC 2026
On Thu, 8 Jan 2026 15:42:42 GMT, Benoît Maillard <bmaillard at openjdk.org> wrote:
>> Galder Zamarreño has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into topic.uses-min-max
>> - Module also needed in the wrapper test class
>> - It's the templated test that needs the module
>> - Add missing module to test
>> - Merge branch 'master' into topic.uses-min-max
>> - Test Float16
>> - Only apply to uses that match original IR node
>> - Merge branch 'master' into topic.uses-min-max
>> - Use is_MinMax() instead of spelling out individual Min/Max opcodes
>> - Refactor MaxNode to MinMaxNode and add is_MinMax() query
>> - ... and 3 more: https://git.openjdk.org/jdk/compare/067fd3cb...7229e345
>
> Looks good to me, thanks for making this change. I like the move from `MaxNode` to `MinMaxNode`, I always thought the naming was a bit confusing.
>
> I have also kicked off internal testing and will come back with the results once done.
The testing that @benoitmaillard ran does not seem to show any related failures. I think the recent changes were not substantial enough to warrant another round of internal testing, GitHub Actions is probably enough.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28895#issuecomment-3737139291
More information about the hotspot-compiler-dev
mailing list