RFR: 8373343: C2: verify AddP base input only set for heap addresses [v5]

[Roland Westrelin]

> The base input of `AddP` is expected to only be set for heap accesses
> but I noticed some inconsistencies so I added an assert in the `AddP`
> constructor and fixed issues that it caught. AFAFICT, the
> inconsistencies shouldn't create issues.

Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:

  Update src/hotspot/share/opto/macroArrayCopy.cpp
  
  Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28769/files
  - new: https://git.openjdk.org/jdk/pull/28769/files/b20f41db..507b8f45

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28769&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28769&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28769.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28769/head:pull/28769

PR: https://git.openjdk.org/jdk/pull/28769