RFR: 8374828: Save load_barrier_on_oop_field_preloaded in aot CodeCache
Coleen Phillimore
coleenp at openjdk.org
Mon Jan 12 16:01:20 UTC 2026
On Thu, 8 Jan 2026 23:18:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Save this address so that the code that uses it in the valhalla repo will have it. This doesn't fail in main jdk repository.
> See CR for more information.
> Tested with tier1-4.
I're read these comments and @TobiHartmann in the JBS issue:
https://bugs.openjdk.org/browse/JDK-8374828?focusedId=14845838&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14845838
I had assumed that if the AOT cache was created with ZGC, it must be used with ZGC. I didn't think the adapters could be GC agnostic in the current code, or see no evidence of it.
I could make this change simply in the Valhalla repo because it fixes crashes, but wanted to do it in mainline because it'll get lost and forgotten in valhalla with other things. I could file a new issue to reexamine this (but is including the other ZGC barrier method -load_barrier_on_phantom_oop_field_preloaded_addr - wrong but not this one?). Should it be a mainline issue?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29129#issuecomment-3739289225
More information about the hotspot-compiler-dev
mailing list