RFR: 8370691: Add new Float16Vector type and enable intrinsification of vector operations supported by auto-vectorizer [v9]
Jatin Bhateja
jbhateja at openjdk.org
Tue Jan 13 09:48:50 UTC 2026
On Wed, 7 Jan 2026 19:29:03 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
>>
>> - Fix from Bhavana Kilambi for failing JTREG regressions on AARCH64
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691
>> - Including test changes from Bhavana Kilambi (ARM)
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691
>> - Optimizing tail handling
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691
>> - Cleanups
>> - Fix failing jtreg test in CI
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691
>> - Cleanups
>> - ... and 13 more: https://git.openjdk.org/jdk/compare/5e7ae281...703f313d
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractSpecies.java line 436:
>
>> 434: } else {
>> 435: assert(Float16.valueOf(i).intValue() == i);
>> 436: }
>
> It would be clearer if the same pattern is copied as for the other types. Assign and assert, no need to check bounds. We don't need to be performant here. (This code may become even clearer when we can leverage patterns on the primitive types and custom numeric types.)
Done
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorShape.java line 277:
>
>> 275: if (etype == Float16.class) {
>> 276: etype = short.class;
>> 277: }
>
> My suggestion may not worth it, but i was wondering if we could get the lane type and then use the carrier type, rather then encoding this more specifically.
Addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r2685649510
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r2685649160
More information about the hotspot-compiler-dev
mailing list