RFR: 8375055: C2: Better dead loop detection printout [v2]

[Aleksey Shipilev]

> Chasing the maddeningly intermittent CTW failure. When C2 fails dead loop verification checks, it prints:
> 
> 
> # Internal Error (/home/shipilev/shipilev-jdk/src/hotspot/share/opto/phaseX.cpp:784), pid=64465, tid=917
> # assert(no_dead_loop) failed: dead loop detected
> 
> 
> It also dumps the bad node graph to tty. This is not really convenient in automated testing and/or driver tests like CTW. With this fix, we now print:
> 
> 
> #  Internal Error (/home/shade/trunks/jdk/src/hotspot/share/opto/phaseX.cpp:776), pid=973305, tid=973372
> #  fatal error: Dead loop detected, node references itself: CastPP
> 
> 
> ...which allows to have more clues where things may go wrong, and allows to classify the failures better as well.
> 
> Additional testing:
>  - [x] Ad-hoc crashes with selected seeds
>  - [x] Linux x86_64 server fastdebug, `hotspot_compiler`
>  - [x] Linux x86_64 server fastdebug, `applications/ctw/modules`

Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:

 - Indenting
 - Only do node name

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29185/files
  - new: https://git.openjdk.org/jdk/pull/29185/files/b0eadca5..037e92dd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29185&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29185&range=00-01

  Stats: 15 lines in 1 file changed: 0 ins; 7 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/29185.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29185/head:pull/29185

PR: https://git.openjdk.org/jdk/pull/29185