RFR: 8374889: C2 VectorAPI: must handle impossible combination of signed cast from float [v2]
Quan Anh Mai
qamai at openjdk.org
Wed Jan 14 03:37:51 UTC 2026
On Wed, 14 Jan 2026 02:38:02 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> intrinsify with Halt instead
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 2345:
>
>> 2343: HaltNode* halt = new HaltNode(control(), frameptr(), ss.as_string(C->comp_arena())
>> 2344: PRODUCT_ONLY(COMMA /*reachable*/false));
>> 2345: _gvn.set_type_bottom(halt);
>
> We create HaltNodes in several places, and all seem to be slightly different. But it seems that more call sites use transform() instead of set_type_bottom().
It seems there is an opportunity to create a method `GraphKit::halt(const char* reason)` that can be called by these places.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29169#discussion_r2688811481
More information about the hotspot-compiler-dev
mailing list