RFR: 8374862: assert(false) failed: Attempting to acquire lock MDOExtraData_lock/nosafepoint-1 out of order with lock tty_lock/tty -- possible deadlock (running with -XX:+Verbose -XX:+WizardMode -XX:+PrintDeoptimizationDetails) [v6]

[Guanqiang Han]

On Thu, 15 Jan 2026 06:37:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Guanqiang Han has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix a compile error
>
> src/hotspot/share/utilities/ostream.hpp line 289:
> 
>> 287:   char* as_string(bool c_heap = false) const;
>> 288:   char* as_string(Arena* arena) const;
>> 289:   bool is_buffered() const { return true; }
> 
> Suggestion:
> 
>   bool is_buffered() const override { return true; }

I originally added override to is_buffered(), but on macOS  the build fails with -Werror -Winconsistent-missing-override. In ostream.hpp, the existing implementations of virtual functions also do not use override, so adding override only to is_buffered() makes the class inconsistent and triggers the warning. I removed it to keep consistency with the current style and avoid the macOS build break.
Do you still want me to add override back (and then update the other overridden methods in this class accordingly)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29186#discussion_r2693199895