RFR: 8347365: C2: Fix the handling of depends_only_on_test [v2]
Manuel Hässig
mhaessig at openjdk.org
Fri Jan 16 17:01:36 UTC 2026
On Fri, 16 Jan 2026 15:59:00 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> src/hotspot/share/opto/callnode.hpp line 123:
>>
>>> 121: virtual bool is_CFG() const { return true; }
>>> 122: virtual uint hash() const { return NO_HASH; } // CFG nodes do not hash
>>> 123: virtual bool depends_only_on_test() const { return false; }
>>
>> Why are you not replacing this with an implementation for depends_only_on_test_impl()? Same question for `RethrowNode`, `GotoNode`, and `RegionNode`.
>
> Because they are CFG nodes, `depends_only_on_test` returns `false` without the need to invoke `depends_only_on_test_impl`.
Ahh, I failed to make that connection. Thanks for the clarification.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29158#discussion_r2699270968
More information about the hotspot-compiler-dev
mailing list