RFR: 8375271: [IR Framework] Rename IREncoding to ApplicableIRRules and driver/flag/test VM to Driver/Flag/Test VM [v2]

Damon Fenacci dfenacci at openjdk.org
Mon Jan 19 08:00:41 UTC 2026


On Wed, 14 Jan 2026 12:34:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This patch is part of a series of patches split of from a prototype implementation for replacing the hotspot-pid file based transfer of IR dumps between the Test VM and the Driver VM with a socket based transfer (see [JDK-8375271](https://bugs.openjdk.org/browse/JDK-8375271) for more information). This should ease reviews.
>> 
>> This patch is about naming updates:
>> 
>> `IREncoding` is quite generic and does not really tell what it is about by looking at its name. I suggest to rename it to `ApplicableIRRules` to better reflect what it is about. I also capitalized the first letter of "driver/flag/test VM" to better indicate that these are proper names.
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update Test VM
>  - Update test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java
>    
>    Co-authored-by: Manuel Hässig <manuel at haessig.org>

Looks good to me. Thanks @chhagedorn!

test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/VMInfoParser.java line 46:

> 44: 
> 45:     /**
> 46:      * Extract VMInfo from the applicableIRRules.

Suggestion:

     * Extract VMInfo from applicableIRRules.

test/hotspot/jtreg/compiler/lib/ir_framework/flag/FlagVM.java line 99:

> 97: 
> 98:     /**
> 99:      * Emit Test VM flags to the dedicated Test VM flags file to parse them from the TestFramework "driver" VM again

Suggestion:

     * Emit Test VM flags to the dedicated Test VM flags file to parse them from the TestFramework Driver VM again

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/29229#pullrequestreview-3676724955
PR Review Comment: https://git.openjdk.org/jdk/pull/29229#discussion_r2703600347
PR Review Comment: https://git.openjdk.org/jdk/pull/29229#discussion_r2703641426


More information about the hotspot-compiler-dev mailing list