RFR: 8373343: C2: verify AddP base input only set for heap addresses [v6]

[Roland Westrelin]

> The base input of `AddP` is expected to only be set for heap accesses
> but I noticed some inconsistencies so I added an assert in the `AddP`
> constructor and fixed issues that it caught. AFAFICT, the
> inconsistencies shouldn't create issues.

Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:

 - Merge branch 'master' into JDK-8373343
 - Update src/hotspot/share/opto/macroArrayCopy.cpp
   
   Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>
 - more
 - more
 - review
 - Merge branch 'master' into JDK-8373343
 - review
 - review
 - review
 - merge
 - ... and 5 more: https://git.openjdk.org/jdk/compare/370d2034...2f618436

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28769/files
  - new: https://git.openjdk.org/jdk/pull/28769/files/507b8f45..2f618436

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28769&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28769&range=04-05

  Stats: 61075 lines in 1252 files changed: 30953 ins; 11926 del; 18196 mod
  Patch: https://git.openjdk.org/jdk/pull/28769.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28769/head:pull/28769

PR: https://git.openjdk.org/jdk/pull/28769