RFR: 8375618: Incorrect assert in CastLLNode::Ideal

Quan Anh Mai qamai at openjdk.org
Tue Jan 20 02:53:31 UTC 2026


On Mon, 19 Jan 2026 17:45:14 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Hi,
>> 
>> This PR fixes the incorrect assert in `CastLLNode::Ideal`. The assert intends to verify that the output is either a proper subset of or the same as the input. It does so by checking the signed lower bound and signed upper bound of the `TypeLong` instances. This method is not correct now.
>> 
>> Please kindly review, thanks a lot.
>
> Should properly_contains be a product or a debug-only function? It is currently only used for debug, wonder what product uses it would see.

@liach Thanks for taking a look, that's a good idea!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29304#issuecomment-3770784796


More information about the hotspot-compiler-dev mailing list