RFR: 8373026: C2 SuperWord and Vector API: vector algorithms test and benchmark [v11]
Emanuel Peter
epeter at openjdk.org
Wed Jan 21 10:01:12 UTC 2026
On Wed, 21 Jan 2026 09:14:41 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> use firstTrue for XiaohongGong
>
> test/hotspot/jtreg/compiler/vectorization/VectorAlgorithmsImpl.java line 486:
>
>> 484: int sum = 0;
>> 485: int i = 0;
>> 486: for (; i < a.length - 3; i+=4) {
>
> Suggestion:
>
> for (; i < a.length - 3; i += 4) {
Will adjust it in all places :)
> test/hotspot/jtreg/compiler/vectorization/VectorAlgorithmsImpl.java line 695:
>
>> 693: for (; i < SPECIES_I.loopBound(oops.length); i += SPECIES_I.length()) {
>> 694: var oopv = IntVector.fromArray(SPECIES_I, oops, i);
>> 695: var mask = oopv.compare(VectorOperators.NE, nulls);
>
> Is this better? `nulls` can be removed although it may have no difference for compilation result?
> Suggestion:
>
> var mask = oopv.compare(VectorOperators.NE, 0);
Nice idea, I adjusted it in both places :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28639#discussion_r2711792269
PR Review Comment: https://git.openjdk.org/jdk/pull/28639#discussion_r2711807184
More information about the hotspot-compiler-dev
mailing list