RFR: 8375618: Incorrect assert in CastLLNode::Ideal [v2]

Quan Anh Mai qamai at openjdk.org
Wed Jan 21 14:26:02 UTC 2026


On Wed, 21 Jan 2026 13:35:14 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make properly_contains debug only
>
> src/hotspot/share/opto/type.cpp line 1820:
> 
>> 1818: 
>> 1819: #ifdef ASSERT
>> 1820: bool TypeInt::properly_contains(const TypeInt* t) const {
> 
> Is `strictly_contains` easier to understand? But from a set theory perspective, "proper" and "strict" are both correct.

That's definitely a more intuitive name, thanks for the suggestion :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29304#discussion_r2712784033


More information about the hotspot-compiler-dev mailing list