RFR: 8373343: C2: verify AddP base input only set for heap addresses [v6]

[Dean Long]

On Mon, 19 Jan 2026 15:32:07 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The base input of `AddP` is expected to only be set for heap accesses
>> but I noticed some inconsistencies so I added an assert in the `AddP`
>> constructor and fixed issues that it caught. AFAFICT, the
>> inconsistencies shouldn't create issues.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8373343
>  - Update src/hotspot/share/opto/macroArrayCopy.cpp
>    
>    Co-authored-by: Dean Long <17332032+dean-long at users.noreply.github.com>
>  - more
>  - more
>  - review
>  - Merge branch 'master' into JDK-8373343
>  - review
>  - review
>  - review
>  - merge
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/1343aafa...2f618436

Marked as reviewed by dlong (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28769#pullrequestreview-3691365766