RFR: 8375653: C2: CmpUNode::sub is not monotonic [v4]
Quan Anh Mai
qamai at openjdk.org
Thu Jan 22 15:01:41 UTC 2026
On Thu, 22 Jan 2026 14:27:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/c2/gvn/CmpUNodeValueTests.java line 86:
>>
>>> 84:
>>> 85: @Test
>>> 86: @IR(applyIfPlatformOr = {"x64", "true", "aarch64", "true"}, failOn = {IRNode.CMP_U, IRNode.CALL})
>>
>> Just as a "control test", can you add a comparison that does not fold away, and so we should find the nodes?
>> Otherwise, the risk is that we do `failOn` for the wrong nodes and don't notice.
>
> Below, it may be more helpful to annotate the tests with what you expect the test folds to: `LT`, `GE`, `NE`, ... It would also make it easier to quickly spot if we have covered all cases.
Done!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29308#discussion_r2717274021
More information about the hotspot-compiler-dev
mailing list