RFR: 8372980: [VectorAPI] AArch64: Add intrinsic support for unsigned min/max reduction operations [v3]

[Andrew Haley]

On Thu, 22 Jan 2026 03:11:04 GMT, Eric Fang <erfang at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1965:
>> 
>>> 1963: // Helper function to decode min/max reduction operation properties
>>> 1964: static void decode_minmax_reduction_opc(int opc, bool& is_min, bool& is_unsigned,
>>> 1965:                                         Assembler::Condition& cond) {
>> 
>> Suggestion:
>> 
>>                                         Condition cond) {
>
> Considering that this function is only used by this file and does not call any instructions, I made it a **file-scope static** function. And as we don't declare `using Assembler::Condition;` in this file, so we have to use `Assembler::Condition&` here, or we'll get the following error:
> 
> jdk/src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp:1965:41: error: ‘Condition’ has not been declared
>  1965 |                                         Condition& cond) {
> 
> As for `&`, this is a reference parameter.
> 
> To remove `Assembler::`, we can
> 1. Declare `using Assembler::Condition;` in this file.
> 2. Make this function as a private method of `C2_MacroAssembler`.
> 
> WDYT ?

I can't see any positive reason not to use Option 2.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28693#discussion_r2717926249