RFR: 8375272: [IR Framework] Miscellaneous clean-ups

Christian Hagedorn chagedorn at openjdk.org
Fri Jan 23 13:22:49 UTC 2026


On Thu, 22 Jan 2026 14:51:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> This patch applies various unrelated clean-ups split out from a first prototype for [JDK-8375270](https://bugs.openjdk.org/browse/JDK-8375270). This should ease reviews. I left some comments in the PR to further explain some details.
> 
> Thanks,
> Christian

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 186:

> 184:     private int defaultWarmup = -1;
> 185:     private boolean testClassesOnBootClassPath;
> 186:     private boolean allowNotCompilable = false;

For consistency.

test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NotCompilableIRMethod.java line 27:

> 25: 
> 26: import compiler.lib.ir_framework.IR;
> 27: import compiler.lib.ir_framework.Test;

Unused + added import for Javadocs. Same below.

test/hotspot/jtreg/compiler/lib/ir_framework/driver/network/testvm/java/IRRuleIds.java line 37:

> 35:  * Class to hold the indices of the applicable {@link IR @IR} rules of an {@link IRMethod}.
> 36:  */
> 37: public class IRRuleIds implements Iterable<Integer> {

Replaced usages of `int[] irRuleIds` with this class.

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java line 188:

> 186:             super(s);
> 187:         }
> 188:     }

Converted to an inner class to make the IDE stop complaining about duplicated classes in tests.

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestSetupTests.java line 364:

> 362: 
> 363: 
> 364:     static class BadCheckedTestException extends RuntimeException {

Same here: Converted to an inner class to make the IDE stop complaining about duplicated classes in tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2717254052
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2717257890
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2721157095
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2717251432
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2717252123


More information about the hotspot-compiler-dev mailing list