RFR: 8376220: C2: Refactor the logic to in MemNode::find_previous_store [v5]

Daniel Lundén dlunden at openjdk.org
Mon Jan 26 16:16:21 UTC 2026


On Sat, 24 Jan 2026 19:28:52 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch refactors the logic in `MemNode::find_previous_store` and makes a small improvement to `MemNode::detect_ptr_independence`. An IR test accompanies the improvement.
>> 
>> Please take a look and share your thoughts, thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test store the loaded vector

Great with a separate refactoring PR, thanks @merykitty!

In addition to adding more tests as @robcasloz suggests, a good stress test is to create an instrumented version of the changeset that runs both the old and new versions, and verifies at runtime that there are no regressions (e.g., an optimization that is inhibited by the new changeset by mistake). Then, you can run this instrumented version on a large set of standard tests. It is a bit of work, but I've found it useful on many occasions in the past. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29390#issuecomment-3800427095


More information about the hotspot-compiler-dev mailing list