RFR: 8376402: Dependencies::print_statistics() and AbstractClassHierarchyWalker::print_statistics() are not called from PRODUCT code [v2]

[Christian Hagedorn]

On Tue, 27 Jan 2026 14:29:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Dependencies::print_statistics() and AbstractClassHierarchyWalker::print_statistics() are not called from PRODUCT code but seems they still end up in the product build JVM, at least when using standard build settings.
>> (This can be observed when enabling link time gc and verbose info printing - in this case the methods are eliminated).
>> 
>> linuxx86_64
>> product build without those methods
>> 
>> ls -alL images/jdk/lib/server/libjvm.so
>> size 2.859.5144
>> 
>> 
>> unchanged product build :
>> 
>> ls -alL images/jdk/lib/server/libjvm.so
>> size 2.859.9464
>> 
>> 
>> (so we see a little size difference)
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust COPYRIGHT year

Thanks for cleaning that up!

src/hotspot/share/code/dependencies.cpp line 2280:

> 2278: }
> 2279: 
> 2280: #ifndef PRODUCT

You should probably also make the declarations of the two methods inside the classes `NOT_PRODUCT`.

-------------

Changes requested by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29449#pullrequestreview-3711638156
PR Review Comment: https://git.openjdk.org/jdk/pull/29449#discussion_r2732371231