RFR: 8371536: C2: VerifyIterativeGVN should assert on first detected failure [v6]

Emanuel Peter epeter at openjdk.org
Tue Jan 27 15:05:48 UTC 2026


On Fri, 16 Jan 2026 17:37:09 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Good point, I didn't think of that. Passing a string into the method would be one solution. Another one would be to keep the `bool` return type for `verify_Value_for` and assert at the call site (just as it was before). I think this feels a bit more natural that passing an assert message as parameter. What do you think?
>
> Perhaps you could change the message to `... PhaseCCP ...` if --- in Java speak --- `this instanceof PhaseCCP` in addition to the comment you added.

Ah, I was supposed to answer here? I think something like passing a `PhaseIterGVN` or `PhaseCCP` string would be a good solution :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28295#discussion_r2732454805


More information about the hotspot-compiler-dev mailing list