RFR: 8350330: C2: PhaseIdealLoop::add_parse_predicate() should mirror GraphKit::add_parse_predicate() [v2]

Roland Westrelin roland at openjdk.org
Tue Jan 27 15:52:43 UTC 2026


> `PhaseIdealLoop::add_parse_predicate()` was intented to mirror
> `GraphKit::add_parse_predicate()` but it doesn't. That last one checks
> `too_many_traps` per bci but the `PhaseIdealLoop` version doesn't. As
> demonstrated by the test case, a method can get compiled with a
> predicate, take a trap, and get recompiled with the same predicate
> many times (up to ~100).

Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into JDK-8350330
 - test & fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29367/files
  - new: https://git.openjdk.org/jdk/pull/29367/files/b1ca0bc4..44832b53

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29367&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29367&range=00-01

  Stats: 16077 lines in 421 files changed: 6992 ins; 2071 del; 7014 mod
  Patch: https://git.openjdk.org/jdk/pull/29367.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29367/head:pull/29367

PR: https://git.openjdk.org/jdk/pull/29367


More information about the hotspot-compiler-dev mailing list