RFR: 8373026: C2 SuperWord and Vector API: vector algorithms test and benchmark [v15]

Emanuel Peter epeter at openjdk.org
Wed Jan 28 07:23:16 UTC 2026


On Wed, 28 Jan 2026 03:32:30 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix IR rule that failed on neon
>
> test/hotspot/jtreg/compiler/vectorization/TestVectorAlgorithms.java line 252:
> 
>> 250:     public Object fillI_VectorAPI(int[] r) {
>> 251:         return VectorAlgorithmsImpl.fillI_VectorAPI(r);
>> 252:     }
> 
> So the IR check only passes because we rely on `fillI_VectorAPI` being inlined, correct? I'm wondering whether it's possible that the method is not inlined as expected and could the IR check fail if so? Does it deserve a `ForceInline` annotation on methods in the `Impl` file?

That's why both the test and the benchmark have the flag `-XX:CompileCommand=inline,*VectorAlgorithmsImpl*::*` so we can avoid the annotations ;)

If I had to do annotation, then it would be `@ForceInline` for the test, and `@CompilerControl(CompilerControl.Mode.INLINE)` for the benchmark. So that would mean the `Impl` files would not be identical.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28639#discussion_r2735192882


More information about the hotspot-compiler-dev mailing list