RFR: 8373591: C2: Fix the memory around some intrinsics nodes [v6]
Quan Anh Mai
qamai at openjdk.org
Fri Jan 30 02:42:51 UTC 2026
> Hi,
>
> This is extracted from #28570 , there are 2 issues here:
>
> - Some intrinsics nodes advertise incorrect `adr_type`. For example, `AryEqNode` reports `adr_type` being `TypeAryPtr::BYTES` (it inherits this from `StrIntrinsicNode`). This is incorrect, however, as it can accept `char[]` inputs, too. Another case is `VectorizedHashCodeNode`, which reports its `adr_type` being `TypePtr::BOTTOM`, but it actually extracts a memory slice and does not consume the whole memory.
> - For nodes such as `StrInflatedCopyNode`, as they consume more than they produce, during scheduling, we need to compute anti-dependencies. This is not the case, so we should fix it by making the nodes kill all the memory they consume. This issue is often not present because these intrinsics are not exposed bare to general usage.
>
> Please kindly review, thanks a lot.
Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
- Add test case for StringCoding::implEncodeAsciiArray
- Merge branch 'master' into intrinsicsadrtype
- Merge branch 'master' into intrinsicsadrtype
- copyright year
- Merge branch 'master' into intrinsicsadrtype
- consolidate the memory effect into a function
- Use MemBar instead of widening the intrinsic memory
- Fix Shenandoah
- Fix memory around intrinsics nodes
-------------
Changes: https://git.openjdk.org/jdk/pull/28789/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28789&range=05
Stats: 341 lines in 6 files changed: 227 ins; 13 del; 101 mod
Patch: https://git.openjdk.org/jdk/pull/28789.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28789/head:pull/28789
PR: https://git.openjdk.org/jdk/pull/28789
More information about the hotspot-compiler-dev
mailing list