Integrated: 8376604: C2: EA should assert is_oop_field for AddP with oop outs
Aleksey Shipilev
shade at openjdk.org
Fri Jan 30 08:34:44 UTC 2026
On Wed, 28 Jan 2026 18:30:15 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Split out of [JDK-8376514](https://bugs.openjdk.org/browse/JDK-8376514) in Valhalla: I think we need to verify more thoroughly that if we reply is_oop_field = false for AddP, then there are no nodes that we feed into oops. We handle it pretty well in various branches in the method already, and we "just" need to check it at the end. Valhalla catches fire on that post-condition check, tracked in [JDK-8376514](https://bugs.openjdk.org/browse/JDK-8376514).
>
> Cleans up the code a bit as well.
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `applications/ctw/modules`, 20x, no failures
> - [x] Linux x86_64 server fastdebug, `hotspot_compiler`
This pull request has now been integrated.
Changeset: e6437264
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e6437264d5e6d4aad23430b7dbdf574a12b8f57b
Stats: 20 lines in 2 files changed: 10 ins; 6 del; 4 mod
8376604: C2: EA should assert is_oop_field for AddP with oop outs
Reviewed-by: qamai, kvn
-------------
PR: https://git.openjdk.org/jdk/pull/29468
More information about the hotspot-compiler-dev
mailing list