<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi,<br>
<br>
looks good to me (not a reviewer).<br>
<br>
Thanks,<br>
Dmitrij<br>
<blockquote cite="mid:577545FD.1010203@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<font face="Helvetica, Arial, sans-serif">Hello,<br>
<br>
</font><font face="Helvetica, Arial, sans-serif">could you please
review this patch?<br>
<br>
This review request covers two bugs:<br>
- 8151280: update hotspot tests to use vm.compMode instead of
their own logic [1]<br>
- 8145848: Update hs compiler tests to get VM mode using
j.t.l.Platform [2]<br>
Also it relays on bug fix for 8132919 [3] which I posted
recently [4]<br>
<br>
Summary:<br>
it's possible now to rely on @requires expressions to choose
vm.compMode<br>
</font><font face="Helvetica, Arial, sans-serif">At the moment
several compiler tests parse java.vm.info property to get VM
mode. It could be done using j.t.l.Platform.<br>
<br>
This patch has been contributed by Igor Ignatyev.<br>
<br>
Tested on on Linux-x86 and Solaris sparc<br>
<br>
top level webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eiignatyev/8145848/top/webrev.00/">http://cr.openjdk.java.net/~iignatyev/8145848/top/webrev.00/</a><br>
hotspot webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eiignatyev/8145848/hotspot/webrev.00/">http://cr.openjdk.java.net/~iignatyev/8145848/hotspot/webrev.00/</a><br>
bugs: [1] [2]<br>
<br>
[1] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8151280">https://bugs.openjdk.java.net/browse/JDK-8151280</a><br>
[2] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8145848">https://bugs.openjdk.java.net/browse/JDK-8145848</a><br>
[3] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8132919">https://bugs.openjdk.java.net/browse/JDK-8132919</a><br>
[4]
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-June/023599.html">http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-June/023599.html</a><br>
<br>
Thanks,<br>
Tatiana<br>
</font> </blockquote>
<br>
</body>
</html>